Discussion:
Tapestry 5.5?
Jochen Kemnade
2017-10-10 16:03:02 UTC
Permalink
Hi,

you may have noticed that the most recent Tapestry release (5.4.3) does not
work with Java 9. This is mainly due to an outdated ASM release that we use
in plastic.
I have upgraded ASM to the latest stable release in the master branch,
along with some other dependencies (such as Selenium) and Gradle.
Rather than struggling with backports for 5.4, I'd say that we concentrate
on finishing 5.5.
I'm creating a 5.5-alpha-4 preview release right now and would like to move
on to beta stage (along with a first public release of the 5.5 line) soon.
Is there anything we need to do before that? Any blocker issues that come
to mind?
I've used 5.5-alpha-3 in production for several months now and have not
encountered any regression issues. Has anyone else given it a try?
Also, does anyone else have some spare time to help finish the release?

Jochen
Michael N. Mikhulya
2017-10-13 06:39:52 UTC
Permalink
Hi,

I tried 5.5-alpha-3.
It works like a charm.

Thank you for your efforts!
Post by Jochen Kemnade
Hi,
you may have noticed that the most recent Tapestry release (5.4.3) does not
work with Java 9. This is mainly due to an outdated ASM release that we use
in plastic.
I have upgraded ASM to the latest stable release in the master branch,
along with some other dependencies (such as Selenium) and Gradle.
Rather than struggling with backports for 5.4, I'd say that we concentrate
on finishing 5.5.
I'm creating a 5.5-alpha-4 preview release right now and would like to move
on to beta stage (along with a first public release of the 5.5 line) soon.
Is there anything we need to do before that? Any blocker issues that come
to mind?
I've used 5.5-alpha-3 in production for several months now and have not
encountered any regression issues. Has anyone else given it a try?
Also, does anyone else have some spare time to help finish the release?
Jochen
Thiago H. de Paula Figueiredo
2017-10-13 21:20:51 UTC
Permalink
Post by Jochen Kemnade
Hi,
Hello!
Post by Jochen Kemnade
you may have noticed that the most recent Tapestry release (5.4.3) does not
work with Java 9. This is mainly due to an outdated ASM release that we use
in plastic.
I haven't had a chance to play with Java 9 yet. Thanks for the info!
Post by Jochen Kemnade
I have upgraded ASM to the latest stable release in the master branch,
along with some other dependencies (such as Selenium) and Gradle.
Thanks!
Post by Jochen Kemnade
Rather than struggling with backports for 5.4, I'd say that we concentrate
on finishing 5.5.
Is there any struggle with backporting stuff for 5.4? I'd guess the ASM
upgrade
was just updating the version. Was it?
Post by Jochen Kemnade
I'm creating a 5.5-alpha-4 preview release right now and would like to move
on to beta stage (along with a first public release of the 5.5 line) soon.
Thanks!
Post by Jochen Kemnade
Is there anything we need to do before that? Any blocker issues that come
to mind?
I cannot think of anything right now.
Post by Jochen Kemnade
I've used 5.5-alpha-3 in production for several months now and have not
encountered any regression issues. Has anyone else given it a try?
Also, does anyone else have some spare time to help finish the release?
Next week is complicated for me, but the following one I can schedule some
time to help you.
--
Thiago
Jochen Kemnade
2017-10-16 09:02:28 UTC
Permalink
Hi,
Post by Thiago H. de Paula Figueiredo
Is there any struggle with backporting stuff for 5.4? I'd guess the ASM
upgrade
was just updating the version. Was it?
Basically yet. Since we repackage ASM under the Tapestry namespace, I had to extract the new sources, remove a package that we don't use, and increase a method's invisibility (we have been doing that for a while).
But I don't know if ASM 6 is compatible with Java 6 (which we still support in the 5.4 line).
Post by Thiago H. de Paula Figueiredo
Post by Jochen Kemnade
I've used 5.5-alpha-3 in production for several months now and have not
encountered any regression issues. Has anyone else given it a try?
Also, does anyone else have some spare time to help finish the release?
Next week is complicated for me, but the following one I can schedule some
time to help you.
Great, let's make a public beta next week and see what needs to be done for a final release.

Jochen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@tapestry.apache.org
For additional commands, e-mail: dev-***@tapestry.apache.org
Michael N. Mikhulya
2017-10-16 10:30:06 UTC
Permalink
Hi,

is it possible to apply patch from
https://issues.apache.org/jira/browse/TAP5-2558

while we are in alfa stage?
Post by Jochen Kemnade
Hi,
Post by Thiago H. de Paula Figueiredo
Is there any struggle with backporting stuff for 5.4? I'd guess the ASM
upgrade
was just updating the version. Was it?
Basically yet. Since we repackage ASM under the Tapestry namespace, I had
to extract the new sources, remove a package that we don't use, and
increase a method's invisibility (we have been doing that for a while).
But I don't know if ASM 6 is compatible with Java 6 (which we still
support in the 5.4 line).
Post by Thiago H. de Paula Figueiredo
Post by Jochen Kemnade
I've used 5.5-alpha-3 in production for several months now and have not
encountered any regression issues. Has anyone else given it a try?
Also, does anyone else have some spare time to help finish the release?
Next week is complicated for me, but the following one I can schedule
some
Post by Thiago H. de Paula Figueiredo
time to help you.
Great, let's make a public beta next week and see what needs to be done
for a final release.
Jochen
---------------------------------------------------------------------
Jochen Kemnade
2017-10-16 11:51:12 UTC
Permalink
Thanks for the patch and the reminder, Michael.

I think that is is safe to apply the patch.
If mutiple threads arrive at the loader.loadClass(className) call at the same time, the PlasticClassLoader's loadClass implementation will synchronize anyway.
So, if there are no objections, I'll merge the patch into master later this week.

Jochen
Post by Michael N. Mikhulya
Hi,
is it possible to apply patch from
https://issues.apache.org/jira/browse/TAP5-2558
while we are in alfa stage?
Post by Jochen Kemnade
Hi,
Post by Thiago H. de Paula Figueiredo
Is there any struggle with backporting stuff for 5.4? I'd guess the ASM
upgrade
was just updating the version. Was it?
Basically yet. Since we repackage ASM under the Tapestry namespace, I had
to extract the new sources, remove a package that we don't use, and
increase a method's invisibility (we have been doing that for a while).
But I don't know if ASM 6 is compatible with Java 6 (which we still
support in the 5.4 line).
Post by Thiago H. de Paula Figueiredo
Post by Jochen Kemnade
I've used 5.5-alpha-3 in production for several months now and have not
encountered any regression issues. Has anyone else given it a try?
Also, does anyone else have some spare time to help finish the release?
Next week is complicated for me, but the following one I can schedule
some
Post by Thiago H. de Paula Figueiredo
time to help you.
Great, let's make a public beta next week and see what needs to be done
for a final release.
Jochen
---------------------------------------------------------------------
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@tapestry.apache.org
For additional commands, e-mail: dev-***@tapestry.apache.org
Thiago H. de Paula Figueiredo
2017-10-16 12:56:27 UTC
Permalink
The patch looks good to me. Thanks, Michael!
Post by Jochen Kemnade
Thanks for the patch and the reminder, Michael.
I think that is is safe to apply the patch.
If mutiple threads arrive at the loader.loadClass(className) call at the
same time, the PlasticClassLoader's loadClass implementation will
synchronize anyway.
So, if there are no objections, I'll merge the patch into master later this week.
Jochen
----- Am 16. Okt 2017 um 12:30 schrieb Michael N. Mikhulya
Post by Michael N. Mikhulya
Hi,
is it possible to apply patch from
https://issues.apache.org/jira/browse/TAP5-2558
while we are in alfa stage?
On Mon, Oct 16, 2017 at 12:02 PM, Jochen Kemnade <
Hi,
----- Am 13. Okt 2017 um 23:20 schrieb Thiago H. de Paula Figueiredo
Post by Thiago H. de Paula Figueiredo
Is there any struggle with backporting stuff for 5.4? I'd guess the
ASM
Post by Michael N. Mikhulya
Post by Thiago H. de Paula Figueiredo
upgrade
was just updating the version. Was it?
Basically yet. Since we repackage ASM under the Tapestry namespace, I
had
Post by Michael N. Mikhulya
to extract the new sources, remove a package that we don't use, and
increase a method's invisibility (we have been doing that for a while).
But I don't know if ASM 6 is compatible with Java 6 (which we still
support in the 5.4 line).
Post by Thiago H. de Paula Figueiredo
Post by Jochen Kemnade
I've used 5.5-alpha-3 in production for several months now and have
not
Post by Michael N. Mikhulya
Post by Thiago H. de Paula Figueiredo
Post by Jochen Kemnade
encountered any regression issues. Has anyone else given it a try?
Also, does anyone else have some spare time to help finish the
release?
Post by Michael N. Mikhulya
Post by Thiago H. de Paula Figueiredo
Next week is complicated for me, but the following one I can schedule
some
Post by Thiago H. de Paula Figueiredo
time to help you.
Great, let's make a public beta next week and see what needs to be done
for a final release.
Jochen
---------------------------------------------------------------------
---------------------------------------------------------------------
--
Thiago
Thiago H. de Paula Figueiredo
2017-10-16 12:55:08 UTC
Permalink
Post by Jochen Kemnade
Hi,
Hello!
Post by Jochen Kemnade
Post by Thiago H. de Paula Figueiredo
Is there any struggle with backporting stuff for 5.4? I'd guess the ASM
upgrade
was just updating the version. Was it?
Basically yet. Since we repackage ASM under the Tapestry namespace, I had
to extract the new sources, remove a package that we don't use, and
increase a method's invisibility (we have been doing that for a while).
As soon as I took at look at the latest Tapestry commits this weekend, I
noticed that.
Post by Jochen Kemnade
But I don't know if ASM 6 is compatible with Java 6 (which we still
support in the 5.4 line).
Good question. Anyway, we can argue that we only support Java 9 from T5.5
onwards.
Post by Jochen Kemnade
Great, let's make a public beta next week and see what needs to be done
for a final release.
Awesome!
Post by Jochen Kemnade
Jochen
---------------------------------------------------------------------
--
Thiago
Loading...